Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update tutorial. Use path over repath . #2109

Closed
wants to merge 2 commits into from
Closed

chore: Update tutorial. Use path over repath . #2109

wants to merge 2 commits into from

Conversation

michaelhenry
Copy link

@michaelhenry michaelhenry commented Jun 21, 2024 •
edited
Loading

path is more intuitive to use than repath as an example.

@michaelhenry michaelhenry changed the title chore: path is more intuitive to use than repath. chore: Update tutorial. Use path over repath . Jun 21, 2024
@carltongibson
Copy link
Member

I'm not sure we can merge this. See #1338 (and https://github.com/django/channels/commits/85f4b904b2450358caa9419b074adb03abf12665/docs/tutorial/part_2.rst — there was a regression in #1273 because of this).

@michaelhenry
Copy link
Author

@carltongibson gotcha. Happy to close this. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigfootjon bigfootjon bigfootjon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelhenry @carltongibson @bigfootjon